Bug 260789 - Use 'isPercentOrCalculated' across Table Layout Code
Summary: Use 'isPercentOrCalculated' across Table Layout Code
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-28 05:08 PDT by Ahmad Saleem
Modified: 2023-10-09 16:58 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-08-28 05:08:19 PDT 
Hi Team,

It makes sense to use 'isPercentOrCalculated' rather than just 'isPercent' because if we have non-percent in 'calc()' used on Table Layout, we can get crashes (happened in e.g., bug 253841).

Just wanted to raise, so we can fix it.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-09-04 05:09:13 PDT 
<rdar://problem/114931755>
Comment 2 Ahmad Saleem 2023-10-09 16:58:05 PDT 
PR - https://github.com/WebKit/WebKit/pull/17122

I was doing this PR to fix 'fixed-layout-calc-width-001.html' and 'auto-layout-calc-width-001.html', which Alan is now tackling.

Closing this PR and marking this bug as 'RESOLVED WONTFIX'.