Bug 253841 – Ignore calc() values on colgroup elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across following commit, which can be merged and in local testing on WebKit ToT, it fixes following test:

Test Case - https://jsfiddle.net/a0r9q1p3/show

^ Fails in Safari Technology Preview 165. Passes in Chrome Canary 113 and Firefox Nightly 112.

Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=193912

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/AutoTableLayout.cpp#157

^ I am not going to add FIXME, because I am planning to look into fixing by merging other subsequent Blink patches as well after local testing.

Just wanted to raise so I can fix it.

It might progress - auto-layout-calc-width-001.html test case as well.

Thanks!

[EWS]

Committed 261623@main (f013f2c88a3b): <https://commits.webkit.org/261623@main>

Reviewed commits have been landed. Closing PR #11457 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/106692191>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 254038

[Ahmad Saleem]

I just ran full css-tables suite of WPT via --debug flag on top of 269151@main (debug build) and didn't get any debug crash or assert failure.

I think post Alan's fix of bug 262918, it seems we can land this.

Going to do PR now.

[Ahmad Saleem]

Another PR attempt - https://github.com/WebKit/WebKit/pull/18900

[EWS]

Committed 269200@main (a47442a35d9c): <https://commits.webkit.org/269200@main>

Reviewed commits have been landed. Closing PR #18900 and removing active labels.