Bug 253841 - Ignore calc() values on colgroup elements
Summary: Ignore calc() values on colgroup elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 254038
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-13 12:57 PDT by Ahmad Saleem
Modified: 2023-10-11 07:28 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-03-13 12:57:05 PDT
Hi Team,

While going through Blink's commit, I came across following commit, which can be merged and in local testing on WebKit ToT, it fixes following test:

Test Case - https://jsfiddle.net/a0r9q1p3/show

^ Fails in Safari Technology Preview 165. Passes in Chrome Canary 113 and Firefox Nightly 112.

Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=193912

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/AutoTableLayout.cpp#157

^ I am not going to add FIXME, because I am planning to look into fixing by merging other subsequent Blink patches as well after local testing.

Just wanted to raise so I can fix it.

It might progress - auto-layout-calc-width-001.html test case as well.

Thanks!
Comment 1 EWS 2023-03-14 03:29:16 PDT
Committed 261623@main (f013f2c88a3b): <https://commits.webkit.org/261623@main>

Reviewed commits have been landed. Closing PR #11457 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-03-14 03:30:18 PDT
<rdar://problem/106692191>
Comment 3 WebKit Commit Bot 2023-03-16 10:58:16 PDT
Re-opened since this is blocked by bug 254038
Comment 4 Ahmad Saleem 2023-10-10 12:01:04 PDT
I just ran full css-tables suite of WPT via --debug flag on top of 269151@main (debug build) and didn't get any debug crash or assert failure.

I think post Alan's fix of bug 262918, it seems we can land this.

Going to do PR now.
Comment 5 Ahmad Saleem 2023-10-10 12:12:59 PDT
Another PR attempt - https://github.com/WebKit/WebKit/pull/18900
Comment 6 EWS 2023-10-11 07:28:06 PDT
Committed 269200@main (a47442a35d9c): <https://commits.webkit.org/269200@main>

Reviewed commits have been landed. Closing PR #18900 and removing active labels.