Bug 260731 – [SOUP] Fix 'wpt/loading/preload*' test cases which are failing in WebGTK & WPE

• Status: NEW
• Component: WebKitGTK

[Ahmad Saleem]

Hi Team,

While fixing bug 253462, I noticed for no obvious reasons, the added WPT tests are failing and already added WPT test started failing in WPE-WK2 and GTK-WK2.

Further discussion with @mcatanzaro on GTK Slack Channel highlighted that it could be issue in 'libsoup' network backend and it would be good to just add 'failure' or 'skip' expectation by raising bug and land PR.

Hence, I am raising this bug to track these test failures and make them pass in future.

Thanks!

[Michael Catanzaro]

I'm trying to copy the error message from the EWS, but it seems we're having infrastructure problems with ews-build.webkit.org currently as I'm getting a 504 Gateway Time-out when trying to display the test results. The failed runs are linked from GitHub here:

https://github.com/WebKit/WebKit/pull/17043#issuecomment-1693319193

I remember some very specific and suspicious error message that should be pasted into this bug report so we can investigate it. Something about one outstanding request should not delay processing of another request.

[Ahmad Saleem]

@Akash & @Jonathan - Are these logs something you can share or it would be with Igalia?

WPE-WK2 Failure: https://ews-build.webkit.org/#/builders/34/builds/17581

GTK-WK2 Failure: https://ews-build.webkit.org/#/builders/1/builds/21480

[Michael Catanzaro]

(In reply to Ahmad Saleem from comment #2)
> @Akash & @Jonathan - Are these logs something you can share or it would be
> with Igalia?

I guess ews-build.webkit.org recovered in the 20 minutes between my comment and yours. Now that it has recovered, we can see the test results:

--- /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt
+++ /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-actual.txt
@@ -4,5 +4,5 @@
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
 
-PASS Imported inline CSS with no quote is not blocked on pending CSS
+FAIL Imported inline CSS with no quote is not blocked on pending CSS assert_true: The second resource start time should not be blocked on the first resource response expected true got false


Most of them look like that, but I also see:

--- /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/preload/onerror-event-expected.txt
+++ /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/preload/onerror-event-actual.txt
@@ -1,14 +1,3 @@
-CONSOLE MESSAGE: <link rel=preload> must have a valid `as` value
-CONSOLE MESSAGE: <link rel=preload> cannot have the empty string as `as` value
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/dummy.js was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/dummy.css was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/square.png was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/Ahem.ttf was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/test.mp4 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/test.oga was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/security/captions.vtt was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: The resource http://web-platform.test:8800/preload/non-existent/dummy.xml?fetch was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
-CONSOLE MESSAGE: Error: assert_true: video triggered error event expected true got false
 
 FAIL Makes sure that preloaded resources trigger the onerror event Error: assert_true: video triggered error event expected true got false


Kind of looks like preloading is not working anymore at all? Anyway, I doubt your pull request https://github.com/WebKit/WebKit/pull/17043 broke anything.