Bug 253462 – CSS @imports in HTML missing semi-colon and space are mistakenly hidden from CSSPreload Scanner

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Ahmad Saleem]

Hi Team,

This is continuation bug from bug 191466, where merging Chromium / Blink patch has now resolved one case from our CSS Preloader where 'quote-marks' work.

Attaching Chromium / Blink patch resulted in failing following testcase:

http/tests/loading/preload-css-import-layer.html

______

Antti suggested that it could be because of following:

I think this is wrong since there may be more things to parse after the first ) like in

url("foo.css") layer(foo)

This is causing the test failure.

_____

WPT Test Case - https://wpt.fyi/results/loading?label=master&label=experimental&aligned=&view=subtest&q=loading%2F

preloader-css-import-no-space.tentative.html & preloader-css-import-no-semicolon.tentative.html

_____

Following was skipped from Chromium / Blink patch:

// When reading the rule and hitting ')', which signifies the URL end, emit the rule.
            if (c == ')')
                emitRule();  

While this patch seems to suggest 'Chromium' support of layers in CSS Preloader:

https://chromium.googlesource.com/chromium/src/+/d53bf2d989eb0756ae2689f1b16c2875e5384e5e

_________

Just wanted to raise this so we can track failing test cases and fix them since all other browsers are passing them.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/106666050>

[Ahmad Saleem]

I have local patch, which progress these two tests but don't know if it cause any other regression, I will do draft PR to test and document (if I couldn't manage to land for any reason).

[EWS]

Committed 267322@main (af134e645543): <https://commits.webkit.org/267322@main>

Reviewed commits have been landed. Closing PR #17043 and removing active labels.