Bug 26068 - V8: Remove usage of v8::Locker in timer callbacks
Summary: V8: Remove usage of v8::Locker in timer callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-28 14:33 PDT by Dmitry Titov
Modified: 2009-05-28 16:45 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.41 KB, patch)
2009-05-28 14:40 PDT, Dmitry Titov
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-05-28 14:33:31 PDT
Since we have switched to running 1 worker per worker process, we've been removing the v8 locks from the code to avoid triggering unnecessary api checks. This is one of the v8::Locker usages that's left.
Comment 1 Dmitry Titov 2009-05-28 14:40:15 PDT
Created attachment 30749 [details]
Proposed patch

This completes the fix for bug 25944, since the patches for enabling timers and that bug have "crossed in the queue".

Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
Comment 2 Dmitry Titov 2009-05-28 16:45:20 PDT
Landed: http://trac.webkit.org/changeset/44256