Bug 25944 - [V8] Remove the uses of V8 Locker in worker execution code.
Summary: [V8] Remove the uses of V8 Locker in worker execution code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-21 13:15 PDT by Jian Li
Modified: 2009-05-26 16:00 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (4.18 KB, patch)
2009-05-21 13:40 PDT, Jian Li
eric: review-
Details | Formatted Diff | Diff
Proposed Patch (4.48 KB, patch)
2009-05-22 16:29 PDT, Jian Li
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-05-21 13:15:27 PDT
Remove the uses of V8 Locker in worker execution code.
Comment 1 Jian Li 2009-05-21 13:40:36 PDT
Created attachment 30553 [details]
Proposed Patch
Comment 2 Eric Seidel (no email) 2009-05-22 07:06:52 PDT
Comment on attachment 30553 [details]
Proposed Patch

Your ChangeLog needs explanation as to why this change is correct and necessary.

Is this possible to test?  If so it needs a test case. If not, then the ChangeLog needs and explanation of why it's not possible to test, and possibly a link to a bug requesting additional features in our testing framework.  Since it's not possible to run DumpRenderTree with V8 such a bug would be against test_shell in the Chromium tree.

Thanks for the patch!  Dimitri is probably your best reviewer for actual content however.  Above was mostly just me applying standard patch review policy. :)
Comment 3 Jian Li 2009-05-22 16:29:56 PDT
Created attachment 30596 [details]
Proposed Patch

I've changed the ChangeLog per your feedback. Thanks.
Comment 4 Jian Li 2009-05-26 16:00:43 PDT
Committed as http://trac.webkit.org/changeset/44162