Bug 259090 - [Win][Clang] gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePathSeparatorString'
Summary: [Win][Clang] gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 171618
  Show dependency tree / graph
 
Reported: 2023-07-10 18:40 PDT by Fujii Hironori
Modified: 2023-07-12 22:36 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-07-10 18:40:16 PDT 
clang-cl reports a warning:

[1168/6517] Building CXX object Source\ThirdParty\gtest\CMakeFiles\gtest.dir\src\gtest-filepath.cc.obj
C:\home\webkit\gc\Source\ThirdParty\gtest\src\gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePathSeparatorString' [-Wunused-const-variable]
const char kAlternatePathSeparatorString[] = "/";
           ^
1 warning generated.
Comment 1 Fujii Hironori 2023-07-10 18:41:11 PDT 
clang-cl doesn't reprot this warning for the upstream google-test.
It's using gtest-all.cc. Let's use it in WebKit too.
Comment 2 Fujii Hironori 2023-07-10 18:51:07 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15723
Comment 3 EWS 2023-07-12 22:35:02 PDT 
Committed 266025@main (805f2b51a351): <https://commits.webkit.org/266025@main>

Reviewed commits have been landed. Closing PR #15723 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-07-12 22:36:17 PDT 
<rdar://problem/112178499>