Bug 258439 – AX: Improve accessibility for tables and table components with display flex, grid, block, inline-block, and contents

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

https://bugs.webkit.org/show_bug.cgi?id=258223 did the hard work of computing table structure based on the DOM rather than the render tree. But even after that patch, tables and table components with assorted display values are often inaccessible to VoiceOver (likely due to parent-child mismatches caused by anonymous table renderers generated when these display values are used).

[Radar WebKit Bug Importer]

<rdar://problem/111202843>

[Tyler Wilcock]

Created attachment 466808 [details]
Patch

[chris fleizach]

Comment on attachment 466808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466808&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2255
> +    if (m_renderer->isAnonymous() && (is<RenderTableRow>(m_renderer) || is<RenderTable>(m_renderer)))

should we move this above line 2246, and add the TableCell check there, so all our anonymous check types are together?

[Tyler Wilcock]

Created attachment 466817 [details]
Patch

[Tyler Wilcock]

*** Bug 141524 has been marked as a duplicate of this bug. ***

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 466808 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466808&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2255
> > +    if (m_renderer->isAnonymous() && (is<RenderTableRow>(m_renderer) || is<RenderTable>(m_renderer)))
> 
> should we move this above line 2246, and add the TableCell check there, so
> all our anonymous check types are together?
Fixed!

[EWS]

Committed 265486@main (5da3ca144678): <https://commits.webkit.org/265486@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466817 [details].