WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257853
[WPT export friction] Run WPT lint as part of WebKit development via check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=257853
Summary
[WPT export friction] Run WPT lint as part of WebKit development via check-we...
Anne van Kesteren
Reported
2023-06-08 08:59:41 PDT
We should run WPT lint as part of our own listing infrastructure to ensure exports to WPT don't run into issues that would have been easily addressed ahead-of-time.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-06-15 09:00:22 PDT
<
rdar://problem/110843279
>
Jonathan Bedard
Comment 2
2023-06-22 08:03:53 PDT
Naively, it seems like check-webkit-style would be the right place for this.
Sam Sneddon [:gsnedders]
Comment 3
2024-05-20 13:15:45 PDT
We currently are meant to blanket ignore everything in LayoutTests (but see
Bug 274407
), so this also implies changing the current ignore rule to run a specific lint on a bunch of LayoutTests.
Sam Sneddon [:gsnedders]
Comment 4
2024-08-22 10:53:13 PDT
***
Bug 278503
has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 5
2024-08-22 12:59:05 PDT
The use-experience here is that if the WPT linter finds an issue when you are exporting a WPT, you have no recourse to fix it and continue the export.
Simon Fraser (smfr)
Comment 6
2024-09-06 12:13:41 PDT
To run the WPT linter manually, you can pass it full paths to new files: ./LayoutTests/imported/w3c/web-platform-tests/wpt lint <list of absolute paths>
Simon Fraser (smfr)
Comment 7
2026-04-17 16:27:06 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/63010
Sam Sneddon [:gsnedders]
Comment 8
2026-05-01 15:23:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/64073
EWS
Comment 9
2026-05-04 10:56:36 PDT
Committed
312533@main
(1c2ce5ed31e5): <
https://commits.webkit.org/312533@main
> Reviewed commits have been landed. Closing PR #64073 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug