Bug 274407 – check-webkit-style failing for Python changes in WPT

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Sneddon [:gsnedders]]

Karl hit the following:

```
% git webkit pr            
From github.com:WebKit/WebKit
 * branch                      main       -> FETCH_HEAD
Current branch 274304-wpt-html-canvas is up to date.
ERROR: Unexpected diff format when parsing a chunk: '100" height="
'
ERROR: Unexpected diff format when parsing a chunk: '100"><p class="fallback">FAIL (fallback content)</p></canvas>'
ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:386:  too many blank lines (2)  [pep8/E303] [5]
ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:484:  continuation line with same indent as next logical line  [pep8/E125] [5]
ERROR: LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py:580:  continuation line over-indented for hanging indent  [pep8/E126] [5]
Total errors found: 3 in 1020 files
style-checker failed, continue uploading pull request?
Retry will amend the commit with your changes. (Yes/Retry/[No]): 
```

This is surprising given on the face of it we should be ignoring all of LayoutTests, per https://github.com/WebKit/WebKit/blob/87181326e4b98e672a0cb51872cb55f7f0dd0ae3/Tools/Scripts/webkitpy/style/checker.py#L478

[Radar WebKit Bug Importer]

<rdar://problem/128408640>

[Karl Dubost]

I wonder if it matches an exception.

https://github.com/WebKit/WebKit/blob/87181326e4b98e672a0cb51872cb55f7f0dd0ae3/Tools/Scripts/webkitpy/style/checker.py#L717-L733
https://github.com/WebKit/WebKit/blob/b1a07690232ffd27093173e2fd66cf65aa0ed777/Tools/Scripts/webkitpy/style/checker.py#L423


The filepath is 
LayoutTests/imported/w3c/web-platform-tests/html/canvas/tools/gentestutilsunion.py

Some logging to do. :)

[Fujii Hironori]

*** Bug 280504 has been marked as a duplicate of this bug. ***

[Fujii Hironori]

https://github.com/WebKit/WebKit/blob/1e0f90c0a4748d952997071013e3836e5306dd1d/Tools/Scripts/webkitpy/style/checker.py#L462

>    re.compile('(?!WebDriverTests).{0,14}.*.py$'),

This regexp in _NEVER_SKIPPED_FILES matches .py files under LayoutTests directory.
This was aded by Bug 246825.

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/34427

[EWS]

Committed 284464@main (1b97d0c6ae2e): <https://commits.webkit.org/284464@main>

Reviewed commits have been landed. Closing PR #34427 and removing active labels.