Bug 256190 - Rename text-edge to text-box-edge to match the latest spec
Summary: Rename text-edge to text-box-edge to match the latest spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 256183
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-01 17:39 PDT by zalan
Modified: 2023-05-02 15:15 PDT (History)
18 users (show)

See Also:

Attachments
Patch (76.54 KB, patch)
2023-05-01 17:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (76.54 KB, patch)
2023-05-01 19:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (76.54 KB, patch)
2023-05-02 10:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (76.54 KB, patch)
2023-05-02 10:45 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (77.48 KB, patch)
2023-05-02 12:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-05-01 17:39:15 PDT 
ssia
Comment 1 zalan 2023-05-01 17:56:22 PDT 
Created attachment 466163 [details]
Patch
Comment 2 zalan 2023-05-01 19:37:12 PDT 
Created attachment 466167 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2023-05-01 21:24:24 PDT 
Comment on attachment 466167 [details]
Patch

The diff is being weird for stuff in LayoutTests/fast/text/, but I verified that the contents properly match the original
Comment 4 zalan 2023-05-02 10:13:25 PDT 
Created attachment 466174 [details]
Patch
Comment 5 zalan 2023-05-02 10:45:35 PDT 
Created attachment 466175 [details]
Patch
Comment 6 zalan 2023-05-02 12:31:14 PDT 
Created attachment 466178 [details]
Patch
Comment 7 EWS 2023-05-02 15:14:46 PDT 
Committed 263612@main (c8f286909017): <https://commits.webkit.org/263612@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466178 [details].
Comment 8 Radar WebKit Bug Importer 2023-05-02 15:15:25 PDT 
<rdar://problem/108811923>