RESOLVED FIXED 256183
Rename leading-trim to text-box-trim to match the latest spec 
https://bugs.webkit.org/show_bug.cgi?id=256183
Summary Rename leading-trim to text-box-trim to match the latest spec
zalan
Reported 2023-05-01 15:55:32 PDT
ssia
Attachments
Patch (51.06 KB, patch)
2023-05-01 16:01 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (51.71 KB, patch)
2023-05-01 19:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-05-01 16:01:13 PDT
Created attachment 466162 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2023-05-01 16:46:01 PDT
Comment on attachment 466162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466162&action=review text-edge needs to be renamed to text-box-edge too, but I guess this can be a separate patch > Source/WebCore/css/CSSPrimitiveValueMappings.h:574 > #define FOR_EACH(CASE) CASE(Normal) CASE(Start) CASE(End) CASE(Both) The initial value is now "none" instead of "normal". > Source/WebCore/css/CSSProperties.json:3793 > "normal", same here > Source/WebCore/rendering/style/RenderStyleConstants.h:690 > Normal, same here
zalan
Comment 3 2023-05-01 16:48:40 PDT
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 466162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466162&action=review > > text-edge needs to be renamed to text-box-edge too, but I guess this can be > a separate patch > > > Source/WebCore/css/CSSPrimitiveValueMappings.h:574 > > #define FOR_EACH(CASE) CASE(Normal) CASE(Start) CASE(End) CASE(Both) > > The initial value is now "none" instead of "normal". > > > Source/WebCore/css/CSSProperties.json:3793 > > "normal", > > same here > > > Source/WebCore/rendering/style/RenderStyleConstants.h:690 > > Normal, > > same here yeah, these are all going to be in separate patches as this is a rename patch on leading-trim.
zalan
Comment 4 2023-05-01 19:29:54 PDT
Created attachment 466165 [details] Patch
EWS
Comment 5 2023-05-02 07:49:49 PDT
Committed 263587@main (9aeb8b696f2d): <https://commits.webkit.org/263587@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466165 [details].
Radar WebKit Bug Importer
Comment 6 2023-05-02 07:50:21 PDT
<rdar://problem/108788823>
Note You need to log in before you can comment on or make changes to this bug.