Bug 255846 - [GTK] Build failure due to EGLNativeWindowType cast when GTK only has Wayland support
Summary: [GTK] Build failure due to EGLNativeWindowType cast when GTK only has Wayland...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Other Linux
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
: 232608 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-04-23 13:13 PDT by Adrian Perez
Modified: 2023-04-24 00:14 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2023-04-23 13:13:38 PDT 
This has been reported at least here:

  https://github.com/Igalia/meta-webkit/issues/331#event-9074131443

And most recently it has been reported a couple of times in the WebKitGTK
public chat room. While we fixed one such cast in bug #178090, there is
still a type conversion in the opposite direction in GLContext.cpp (or
GLContextEGL.cpp in <2.40.x) when calling eglCreateWindowSurface().
Comment 1 Adrian Perez 2023-04-23 13:15:04 PDT 
Note that this happens only with certain drivers' GL/EGL API headers. In
particular the proprietary Mali and Vivante drivers seem to be two main
cases in which this is an issue.
Comment 2 Adrian Perez 2023-04-23 13:18:22 PDT 
*** Bug 232608 has been marked as a duplicate of this bug. ***
Comment 3 Adrian Perez 2023-04-23 13:39:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13083
Comment 4 EWS 2023-04-24 00:13:08 PDT 
Committed 263299@main (973843664d25): <https://commits.webkit.org/263299@main>

Reviewed commits have been landed. Closing PR #13083 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2023-04-24 00:14:18 PDT 
<rdar://problem/108440261>