WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
255442
Page.cpp data: URL style sheet fast path is incorrect
https://bugs.webkit.org/show_bug.cgi?id=255442
Summary
Page.cpp data: URL style sheet fast path is incorrect
Anne van Kesteren
Reported
2023-04-14 01:07:58 PDT
In particular: * It doesn't use the same base64 decoding options. * It looks like it's not case-insensitive. It should probably reuse code from DataURLDecoder.cpp or invoke that directly.
Attachments
Add attachment
proposed patch, testcase, etc.
Karl Dubost
Comment 1
2023-04-16 18:15:45 PDT
I guess this is about:
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebCore/page/Page.cpp#2181-2209
And to use
https://searchfox.org/wubkat/source/Source/WebCore/platform/network/DataURLDecoder.cpp
Radar WebKit Bug Importer
Comment 2
2023-04-16 18:15:55 PDT
<
rdar://problem/108116260
>
Karl Dubost
Comment 3
2023-04-16 18:36:26 PDT
Anne, this part is surprising too.
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebCore/platform/network/DataURLDecoder.cpp#93-94
There is
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WTF/wtf/URL.cpp#370-386
used by decode
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebCore/platform/network/DataURLDecoder.cpp#197-203
but which seems to be used only in this case
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp#652-666
The other decode is used at two places
https://searchfox.org/wubkat/source/Source/WebCore/loader/ResourceLoader.cpp#297
https://searchfox.org/wubkat/source/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp#343
And there is also
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WTF/wtf/URL.cpp#1083-1101
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug