Bug 254973 - Remove Quirk needsToForceUserSelectAndUserDragWhenInstallingImageOverlay on YouTube.com and google.com
Summary: Remove Quirk needsToForceUserSelectAndUserDragWhenInstallingImageOverlay on Y...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL: http://youtube.com/
Keywords: InRadar
Depends on: 233670
Blocks:
  Show dependency tree / graph
 
Reported: 2023-04-03 23:02 PDT by Karl Dubost
Modified: 2023-04-13 00:24 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2023-04-03 23:02:18 PDT 
Steps to reproduce
1. Navigate to a YouTube video.
2. Hover over related video thumbnails that have recognizable text.
3. Drag to select the text.

Ex
At some point, (3) wouldn't work and you would end up not selecting text. 

from Bug 233670
> That said, I just tried this out on YouTube with site-specific hacks disabled, and it now appears to work. Perhaps we don't need this quirk anymore..


This has been tested by Zohreh Momeni and Wenson Hsieh


https://github.com/WebKit/WebKit/blob/e947c7c9fe38b1d388608b24ed2c753ba25fbd76/Source/WebCore/page/Quirks.cpp#L1405-L1424
Comment 1 Karl Dubost 2023-04-03 23:03:10 PDT 
rdar://107576605
Comment 2 Karl Dubost 2023-04-09 22:23:33 PDT 
This is also not necessary anymore for rdar://76500331 which is the same type of failure on Google search.

We will remove both in the same Commit.
Comment 3 Karl Dubost 2023-04-09 22:32:16 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12561
Comment 4 EWS 2023-04-13 00:24:29 PDT 
Committed 262907@main (2dd8ae90d505): <https://commits.webkit.org/262907@main>

Reviewed commits have been landed. Closing PR #12561 and removing active labels.