Bug 233670 – Adjust a Live Text quirk so that it applies to YouTube image thumbnails

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 445489 [details]
Patch

[Devin Rousso]

Comment on attachment 445489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review

rs=me

> Source/WebCore/page/Quirks.cpp:1461
> +    if (host.endsWith(".youtube.com") || host == "youtube.com")

I think we normally use `equalLettersIgnoringASCIICase` and `endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand).

[Wenson Hsieh]

Comment on attachment 445489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review

>> Source/WebCore/page/Quirks.cpp:1461
>> +    if (host.endsWith(".youtube.com") || host == "youtube.com")
> 
> I think we normally use `equalLettersIgnoringASCIICase` and `endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand).

Fixed — thanks for the review!

[Wenson Hsieh]

Created attachment 445575 [details]
Patch for landing

[EWS]

Committed r286366 (244725@main): <https://commits.webkit.org/244725@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445575 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85924733>

[Karl Dubost]

Wenson Hsieh, do you remember the steps to reproduce here?

[Wenson Hsieh]

(In reply to Karl Dubost from comment #7)
> Wenson Hsieh, do you remember the steps to reproduce here?

The steps to reproduce, as I previously recalled, are:
1. Navigate to a YouTube video.
2. Hover over related video thumbnails that have recognizable text.
3. Drag to select the text.

At some point, (3) wouldn't work and you would end up not selecting text. That said, I just tried this out on YouTube with site-specific hacks disabled, and it now appears to work. Perhaps we don't need this quirk anymore..