Bug 233670 - Adjust a Live Text quirk so that it applies to YouTube image thumbnails
Summary: Adjust a Live Text quirk so that it applies to YouTube image thumbnails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-30 16:32 PST by Wenson Hsieh
Modified: 2021-12-01 09:10 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2021-11-30 16:45 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch for landing (3.43 KB, patch)
2021-12-01 08:21 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-11-30 16:32:31 PST
.
Comment 1 Wenson Hsieh 2021-11-30 16:45:54 PST
Created attachment 445489 [details]
Patch
Comment 2 Devin Rousso 2021-11-30 17:20:20 PST
Comment on attachment 445489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review

rs=me

> Source/WebCore/page/Quirks.cpp:1461
> +    if (host.endsWith(".youtube.com") || host == "youtube.com")

I think we normally use `equalLettersIgnoringASCIICase` and `endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand).
Comment 3 Wenson Hsieh 2021-12-01 08:20:11 PST
Comment on attachment 445489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445489&action=review

>> Source/WebCore/page/Quirks.cpp:1461
>> +    if (host.endsWith(".youtube.com") || host == "youtube.com")
> 
> I think we normally use `equalLettersIgnoringASCIICase` and `endsWithIgnoringASCIICase` (or `convertToASCIILowercase` beforehand).

Fixed — thanks for the review!
Comment 4 Wenson Hsieh 2021-12-01 08:21:12 PST
Created attachment 445575 [details]
Patch for landing
Comment 5 EWS 2021-12-01 09:09:50 PST
Committed r286366 (244725@main): <https://commits.webkit.org/244725@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445575 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-01 09:10:26 PST
<rdar://problem/85924733>