Replace all uses of m_offset with Position::deprecatedEditingOffset() Simple search replace, per Darin's suggestion. See attached patch.
Created attachment 29900 [details] Make m_offset private and change all callers to use deprecatedEditingOffset 31 files changed, 278 insertions(+), 150 deletions(-)
I will follow up this patch with a patch which replaces various deprecatedEditingOffset() calls with calls to offsetInContainer() or other functions which don't use the offset directly.
This patch is large, but it's *all* search replace, except for the one change in InsertParagraphSeparatorCommand::doApply which I highlight in the changelog.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Position.cpp M WebCore/dom/Position.h M WebCore/dom/PositionIterator.h M WebCore/dom/Range.cpp M WebCore/editing/ApplyStyleCommand.cpp M WebCore/editing/BreakBlockquoteCommand.cpp M WebCore/editing/CompositeEditCommand.cpp M WebCore/editing/DeleteSelectionCommand.cpp M WebCore/editing/Editor.cpp M WebCore/editing/InsertLineBreakCommand.cpp M WebCore/editing/InsertParagraphSeparatorCommand.cpp M WebCore/editing/InsertTextCommand.cpp M WebCore/editing/MoveSelectionCommand.cpp M WebCore/editing/ReplaceSelectionCommand.cpp M WebCore/editing/SelectionController.cpp M WebCore/editing/TextIterator.cpp M WebCore/editing/TypingCommand.cpp M WebCore/editing/VisiblePosition.cpp M WebCore/editing/VisibleSelection.cpp M WebCore/editing/htmlediting.cpp M WebCore/editing/visible_units.cpp M WebCore/page/AccessibilityObject.cpp M WebCore/page/AccessibilityRenderObject.cpp M WebCore/page/DOMSelection.cpp M WebCore/page/EventHandler.cpp M WebCore/page/Frame.cpp M WebCore/page/mac/AccessibilityObjectWrapper.mm M WebCore/rendering/RenderTextControl.cpp M WebCore/rendering/RenderTreeAsText.cpp M WebKit/mac/WebView/WebFrame.mm Committed r43035