Bug 25472 - Replace all uses of m_offset with Position::deprecatedEditingOffset()
Summary: Replace all uses of m_offset with Position::deprecatedEditingOffset()
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 25056
  Show dependency treegraph
Reported: 2009-04-29 17:13 PDT by Eric Seidel (no email)
Modified: 2009-04-29 18:10 PDT (History)
0 users

See Also:

Make m_offset private and change all callers to use deprecatedEditingOffset (70.03 KB, patch)
2009-04-29 17:24 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-04-29 17:13:21 PDT
Replace all uses of m_offset with Position::deprecatedEditingOffset()

Simple search replace, per Darin's suggestion.  See attached patch.
Comment 1 Eric Seidel (no email) 2009-04-29 17:24:59 PDT
Created attachment 29900 [details]
Make m_offset private and change all callers to use deprecatedEditingOffset

 31 files changed, 278 insertions(+), 150 deletions(-)
Comment 2 Eric Seidel (no email) 2009-04-29 17:25:46 PDT
I will follow up this patch with a patch which replaces various deprecatedEditingOffset() calls with calls to offsetInContainer() or other functions which don't use the offset directly.
Comment 3 Eric Seidel (no email) 2009-04-29 17:26:48 PDT
This patch is large, but it's *all* search replace, except for the one change in InsertParagraphSeparatorCommand::doApply which I highlight in the changelog.
Comment 4 Eric Seidel (no email) 2009-04-29 18:10:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/Position.cpp
	M	WebCore/dom/Position.h
	M	WebCore/dom/PositionIterator.h
	M	WebCore/dom/Range.cpp
	M	WebCore/editing/ApplyStyleCommand.cpp
	M	WebCore/editing/BreakBlockquoteCommand.cpp
	M	WebCore/editing/CompositeEditCommand.cpp
	M	WebCore/editing/DeleteSelectionCommand.cpp
	M	WebCore/editing/Editor.cpp
	M	WebCore/editing/InsertLineBreakCommand.cpp
	M	WebCore/editing/InsertParagraphSeparatorCommand.cpp
	M	WebCore/editing/InsertTextCommand.cpp
	M	WebCore/editing/MoveSelectionCommand.cpp
	M	WebCore/editing/ReplaceSelectionCommand.cpp
	M	WebCore/editing/SelectionController.cpp
	M	WebCore/editing/TextIterator.cpp
	M	WebCore/editing/TypingCommand.cpp
	M	WebCore/editing/VisiblePosition.cpp
	M	WebCore/editing/VisibleSelection.cpp
	M	WebCore/editing/htmlediting.cpp
	M	WebCore/editing/visible_units.cpp
	M	WebCore/page/AccessibilityObject.cpp
	M	WebCore/page/AccessibilityRenderObject.cpp
	M	WebCore/page/DOMSelection.cpp
	M	WebCore/page/EventHandler.cpp
	M	WebCore/page/Frame.cpp
	M	WebCore/page/mac/AccessibilityObjectWrapper.mm
	M	WebCore/rendering/RenderTextControl.cpp
	M	WebCore/rendering/RenderTreeAsText.cpp
	M	WebKit/mac/WebView/WebFrame.mm
Committed r43035