Bug 254694 - [Wasm-GC] Implement br_on_cast and br_on_cast_fail
Summary: [Wasm-GC] Implement br_on_cast and br_on_cast_fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247394
  Show dependency tree / graph
 
Reported: 2023-03-29 14:46 PDT by Asumu Takikawa
Modified: 2023-12-09 11:47 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2023-03-29 14:46:56 PDT 
Currently JSC implements the cast operations ref.cast and ref.test, but does not implement the control versions br_on_cast and br_on_cast_fail.

Note: the validation for these instructions is going to change slightly in the near future I believe (https://github.com/WebAssembly/gc/pull/359/)
Comment 1 Radar WebKit Bug Importer 2023-04-05 14:47:21 PDT 
<rdar://problem/107679687>
Comment 2 Asumu Takikawa 2023-12-08 12:59:22 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21526
Comment 3 EWS 2023-12-09 11:47:25 PST 
Committed 271810@main (92e8b1300f34): <https://commits.webkit.org/271810@main>

Reviewed commits have been landed. Closing PR #21526 and removing active labels.