WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
254403
Simplify baseline search paths (wk1, wk2, ios-simulator)
https://bugs.webkit.org/show_bug.cgi?id=254403
Summary
Simplify baseline search paths (wk1, wk2, ios-simulator)
Sam Sneddon [:gsnedders]
Reported
2023-03-24 04:26:01 PDT
Currently we have a multitude of pretty similar baseline search paths, and it's often unclear where expectations should go. As an attempt to simplify this, I suggest: * The default baseline always corresponds to wk2 (this avoids a necessity to have, e.g., "mac", "mac-wk1", "and "mac-wk2": it becomes clear the wk2 expectation belongs in "mac"). This also implies getting rid of "wk2" as a place with expectations, and potentially adding a "wk1" (though do any ports aside from Apple still maintain WK1 and thus test expectations?). * We move to only having "ios" (and not also "ios-simulator", "ios-device"), as this split is meaningless in WebKit where nobody outside of Apple can run tests on non-Simulator iOS and hence the expectations need to be maintained by Apple anyway. (And, e.g., if someone puts a failing expectation in ios-simulator in WebKit then we can quite easily end up with duplicate expectations between ios-simulator and ios-device, which helps nobody.) Note jbedard did related work in
187099@main
.
Attachments
Current search paths
(82.20 KB, image/png)
2023-06-02 16:16 PDT
,
Sam Sneddon [:gsnedders]
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-24 04:26:11 PDT
<
rdar://problem/107182061
>
Sam Sneddon [:gsnedders]
Comment 2
2023-06-02 16:16:53 PDT
Created
attachment 466573
[details]
Current search paths I think this graph accurately shows the status quo?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug