Bug 25403 – Gradient Fill of text not positioned properly

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Jeff Schiller]

The attached test case shows a bug in WebKit:  The green text should almost completely obscure the red text.  However, the red text is visible in Safari 4 at a different size and position than the green text.

Note that the red text is actually a gradient.  If the gradient was replaced with a solid color (fill="red"), then this problem is no longer present.

This may be related to Bug 25402.

[Jeff Schiller]

Created attachment 29795 [details]
Test Case showing the problem

[Gavin Sherlock]

I don't see a problem with the test case in r42858

[Dirk Schulze]

*** Bug 25402 has been marked as a duplicate of this bug. ***

[Dirk Schulze]

The wrong behavior is caused by wrong values of the drawing rect. eseidel improved boundingBox's in the last days. It should work now. Can you test it again with the latest nightly please?

[Eric Seidel (no email)]

Wow.  This is much better after http://trac.webkit.org/changeset/42950.

Would you consider this fixed, Jeff?  Or do we have more work to do here?

Our rendering looks as good (or better) than FF and Opera.

[Eric Seidel (no email)]

Created attachment 29866 [details]
Add text gradient test to cover

 5 files changed, 43 insertions(+), 0 deletions(-)

[Eric Seidel (no email)]

Thanks for the awesome test case.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/platform/mac/svg/text/text-gradient-positioning-expected.checksum
	A	LayoutTests/platform/mac/svg/text/text-gradient-positioning-expected.png
	A	LayoutTests/platform/mac/svg/text/text-gradient-positioning-expected.txt
	A	LayoutTests/svg/text/text-gradient-positioning.svg
Committed r42966

We might still be using repaintRectInLocalCoordinates() in a few places where we should be using objectBoundingBox(), so related test cases could fail.  But this nice test case you provided "passes" now, as far as I can tell.

Thanks for the great test case!  (You'll see that I changed the text a little to make it more self-documenting, but otherwise landed it as-is.)

[Jeff Schiller]

Looks great to me in nightly from 4/25.  Thanks!