RESOLVED FIXED 252944
Remove a bogus assert in restoreScrollPositionAndViewState 
https://bugs.webkit.org/show_bug.cgi?id=252944
Summary Remove a bogus assert in restoreScrollPositionAndViewState
Ahmad Saleem
Reported 2023-02-25 05:20:49 PST
Hi Team, While going through Blink's commit, I came across following commit, which can be merged with WebKit: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/dea55cb041d519f2f42a85449e3071b3c9813f30 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/loader/HistoryController.cpp#123 It will get rid of FIXME as well. I have looked in bugzilla and came across two bugs similar bug 50331 and bug 36464 touching same assertion. Appreciate if someone can share their input so we can also get rid of this FIXME. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2023-02-27 10:13:32 PST
I think that bug 16952 is the oldest. Simon, Chris, is the analysis still applicable, should the assertion be removed?
Radar WebKit Bug Importer
Comment 2 2023-03-04 05:21:15 PST
<rdar://problem/106232374>
Ahmad Saleem
Comment 3 2023-10-03 10:50:20 PDT
*** Bug 16952 has been marked as a duplicate of this bug. ***
Ahmad Saleem
Comment 4 2023-10-03 10:50:37 PDT
*** Bug 50331 has been marked as a duplicate of this bug. ***
Ahmad Saleem
Comment 5 2023-10-03 10:50:49 PDT
*** Bug 36464 has been marked as a duplicate of this bug. ***
Ahmad Saleem
Comment 6 2023-10-03 10:51:23 PDT
PR - https://github.com/WebKit/WebKit/pull/18559
EWS
Comment 7 2023-10-03 14:49:32 PDT
Committed 268803@main (8a2524e6b2d8): <https://commits.webkit.org/268803@main> Reviewed commits have been landed. Closing PR #18559 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.