Bug 16952 - Reproducible assertion failure in FrameLoader::restoreScrollPositionAndViewState() (m_currentHistoryItem)
Summary: Reproducible assertion failure in FrameLoader::restoreScrollPositionAndViewSt...
Status: RESOLVED DUPLICATE of bug 252944
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://www.leviahon.co.il/article.php...
Keywords: HasReduction, InRadar
Depends on:
Blocks:
 
Reported: 2008-01-20 21:23 PST by mitz
Modified: 2023-10-03 10:50 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2008-01-20 21:23:44 PST 
See also bug 13684 <rdar://problem/5203036>.

ASSERTION FAILED: m_currentHistoryItem
(WebCore/loader/FrameLoader.cpp:3916 void WebCore::FrameLoader::restoreScrollPositionAndViewState())

Steps to reproduce:
1) Go to the URL.
2) Click the black&white photo.
Comment 1 mitz 2008-01-20 21:34:34 PST 
Reduction: enter the following in the address bar:
javascript: window.open().location.reload()
Comment 2 Mark Rowe (bdash) 2008-01-20 21:44:13 PST 
What's the impact of this in a release build?
Comment 3 Mark Rowe (bdash) 2008-01-20 21:45:48 PST 
Just looked at the code:

    ASSERT(m_currentHistoryItem);
    
    // FIXME: As the ASSERT attests, it seems we should always have a currentItem here.
    // One counterexample is <rdar://problem/4917290>
    // For now, to cover this issue in release builds, there is no technical harm to returning
    // early and from a user standpoint - as in the above radar - the previous page load failed 
    // so there *is* no scroll or view state to restore!
    if (!m_currentHistoryItem)
        return;


In a release build this would seem to be harmless.
Comment 4 Mark Rowe (bdash) 2008-01-20 21:47:23 PST 
<rdar://problem/5697153>
Comment 5 Ahmad Saleem 2023-10-03 10:50:20 PDT 

*** This bug has been marked as a duplicate of bug 252944 ***