Bug 25180 - drawRect() outlines are missing in Chromium
Summary: drawRect() outlines are missing in Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-14 07:16 PDT by Stephen White
Modified: 2009-04-15 11:15 PDT (History)
0 users

See Also:


Attachments
Fix for Chromium drawRect() issue. (2.15 KB, patch)
2009-04-14 07:28 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Slight fix to avoid overdraw. (2.16 KB, patch)
2009-04-14 08:21 PDT, Stephen White
dglazkov: review+
Details | Formatted Diff | Diff
Fixed changelog. (2.21 KB, patch)
2009-04-14 14:13 PDT, Stephen White
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2009-04-14 07:16:28 PDT
The stroked outlines for rectangles drawn via PlatformContext::drawRect() in Chromium are missing.
This was introduced in https://bugs.webkit.org/show_bug.cgi?id=24662 (r41805), and the
affected tests were rebaselined with the outlines missing in http://codereview.chromium.org/46097.
Comment 1 Stephen White 2009-04-14 07:28:41 PDT
Created attachment 29466 [details]
Fix for Chromium drawRect() issue.
Comment 2 Stephen White 2009-04-14 08:21:31 PDT
Created attachment 29468 [details]
Slight fix to avoid overdraw.

Slight fix to previous:  don't draw corners twice (might cause a problem with alpha on).
Comment 3 Dimitri Glazkov (Google) 2009-04-14 13:47:10 PDT
Comment on attachment 29468 [details]
Slight fix to avoid overdraw.

Missing bug URL in ChangeLog.
Comment 4 Stephen White 2009-04-14 14:13:41 PDT
Created attachment 29479 [details]
Fixed changelog.
Comment 5 Darin Fisher (:fishd, Google) 2009-04-15 11:15:39 PDT
Landed as:  http://trac.webkit.org/changeset/42547