Bug 24662 - Chromium build fixes.
: Chromium build fixes.
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-03-17 18:33 PST by
Modified: 2009-03-17 23:02 PST (History)


Attachments
Proposed fix. (2.77 KB, patch)
2009-03-17 18:39 PST, David Levin
dglazkov: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-03-17 18:33:33 PST
These are various fixes that had to happen to make Chromium buildable.
------- Comment #1 From 2009-03-17 18:39:20 PST -------
Created an attachment (id=28714) [details]
Proposed fix.
------- Comment #2 From 2009-03-17 18:40:45 PST -------
fyi I noticed a missing space in this line:
        SkRect topBorder = { rect.fLeft, rect.fTop, rect.width(), 1};
and added it locally.
------- Comment #3 From 2009-03-17 20:28:33 PST -------
(From update of attachment 28714 [details])
r=me.

Perhaps modify ChangeLog to have consistent reference to bug url. I like to use this format:

URL
Description
------- Comment #4 From 2009-03-17 23:02:02 PST -------
Committed as r41805.