Bug 24662 - Chromium build fixes.
: Chromium build fixes.
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: David Levin
Depends on:
  Show dependency treegraph
Reported: 2009-03-17 18:33 PDT by David Levin
Modified: 2009-03-17 23:02 PDT (History)
1 user (show)

See Also:

Proposed fix. (2.77 KB, patch)
2009-03-17 18:39 PDT, David Levin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-03-17 18:33:33 PDT
These are various fixes that had to happen to make Chromium buildable.
Comment 1 David Levin 2009-03-17 18:39:20 PDT
Created attachment 28714 [details]
Proposed fix.
Comment 2 David Levin 2009-03-17 18:40:45 PDT
fyi I noticed a missing space in this line:
        SkRect topBorder = { rect.fLeft, rect.fTop, rect.width(), 1};
and added it locally.

Comment 3 Dimitri Glazkov (Google) 2009-03-17 20:28:33 PDT
Comment on attachment 28714 [details]
Proposed fix.


Perhaps modify ChangeLog to have consistent reference to bug url. I like to use this format:

Comment 4 David Levin 2009-03-17 23:02:02 PDT
Committed as r41805.