Bug 25059 – Remove references to dominantScript, getGenericFontForScript

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Dimitri Glazkov (Google)]

These forking patches were rolled out downstream in Chromium tree. See:

http://codereview.chromium.org/56198.

[Dimitri Glazkov (Google)]

Created attachment 29281 [details]
2009-04-06  Simon Fraser  <[e-mail]>


        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=25052

        Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
        because we need to call it at the end of rebuildCompositingLayerTree() once
        we've determined which descendant layers are composited, otherwise
        calculateCompositedBounds() can give the wrong answer.

        Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
        call that explicitly from styleChanged(), if we know a layer update is not pending,
        and similarly from updateAfterLayout().

        Test: compositing/overflow/overflow-positioning.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterLayout):
        (WebCore::RenderLayerBacking::updateGraphicsLayers):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 LayoutTests/ChangeLog                              |   11 +++
 .../compositing/overflow/overflow-positioning.html |   86 ++++++++++++++++++++
 .../overflow-positioning-expected.checksum         |    1 +
 .../overflow/overflow-positioning-expected.png     |  Bin 0 -> 16400 bytes
 .../overflow/overflow-positioning-expected.txt     |   14 +++
 WebCore/ChangeLog                                  |   26 ++++++
 WebCore/rendering/RenderLayer.cpp                  |    2 +
 WebCore/rendering/RenderLayerBacking.cpp           |   14 +---
 WebCore/rendering/RenderLayerCompositor.cpp        |    7 +-
 9 files changed, 149 insertions(+), 12 deletions(-)

[Dimitri Glazkov (Google)]

Created attachment 29282 [details]
WebCore:


2009-04-06  Dave Moore  <[e-mail]>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25031
        Make the V8 element collections check for named properties *before*
        checking if there are any elements with the same name. Otherwise
        it is both incorrect and slow.

        Test: fast/dom/HTMLSelectElement/length-not-overridden.html

        Both of these interceptors were attempting to find an element in the
        collection that had a name or id of the property name before checking
        for a JS property with that name.
        * bindings/v8/V8Collection.h:
        (WebCore::collectionNamedPropertyGetter):
        (WebCore::nodeCollectionNamedPropertyGetter):

LayoutTests:

2009-04-06  Dave Moore  <[e-mail]>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25031
        Test for ensuring that named elements don't override properties on collections

        * fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
        * fast/dom/HTMLSelectElement/length-not-overridden.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 LayoutTests/ChangeLog                              |   10 +++++
 .../length-not-overridden-expected.txt             |    4 ++
 .../HTMLSelectElement/length-not-overridden.html   |   37 ++++++++++++++++++++
 WebCore/ChangeLog                                  |   18 +++++++++
 WebCore/bindings/v8/V8Collection.h                 |   18 +++++++++
 5 files changed, 87 insertions(+), 0 deletions(-)

[Dimitri Glazkov (Google)]

Created attachment 29283 [details]
2009-04-06  Mike Belshe  <[e-mail]>


        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24978
        Use custom implementations of a few Node methods so that
        we don't over-aggressively create JS wrappers here.

        * bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
        * dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 WebCore/ChangeLog                           |   11 ++++
 WebCore/bindings/v8/custom/V8NodeCustom.cpp |   74 +++++++++++++++++++++++++++
 WebCore/dom/Node.idl                        |    8 ++--
 3 files changed, 89 insertions(+), 4 deletions(-)

[Dimitri Glazkov (Google)]

Created attachment 29284 [details]
Remove references to dominantScript, getGenericFontForScript, v1

 WebCore/ChangeLog                                  |   23 +++++++++++++++++++
 .../graphics/chromium/FontCacheChromiumWin.cpp     |   15 ------------
 .../platform/graphics/chromium/FontCacheLinux.cpp  |    7 -----
 WebCore/rendering/RenderThemeChromiumLinux.cpp     |    6 ++--
 WebCore/rendering/RenderThemeChromiumLinux.h       |    2 +-
 WebCore/rendering/RenderThemeChromiumMac.h         |    2 +-
 WebCore/rendering/RenderThemeChromiumMac.mm        |    3 +-
 WebCore/rendering/RenderThemeChromiumWin.cpp       |   24 +++----------------
 WebCore/rendering/RenderThemeChromiumWin.h         |    2 +-
 9 files changed, 34 insertions(+), 50 deletions(-)

[Dimitri Glazkov (Google)]

Sorry for the git-send-bugzilla spam :)

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/42260.