Bug 24978 - Add V8 custom bindings for Node insert/remove methods
Summary: Add V8 custom bindings for Node insert/remove methods
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mike Belshe
Depends on:
Reported: 2009-03-31 19:42 PDT by Mike Belshe
Modified: 2009-04-06 11:09 PDT (History)
0 users

See Also:

patch (3.74 KB, patch)
2009-03-31 19:48 PDT, Mike Belshe
dglazkov: review-
Details | Formatted Diff | Diff
updated patch to address comments. (4.96 KB, patch)
2009-04-05 14:17 PDT, Mike Belshe
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2009-03-31 19:42:55 PDT
This change allows us to take advantage of WebKit's lazyattach, which provides a significant performance win on dom manipulations.
Comment 1 Mike Belshe 2009-03-31 19:48:50 PDT
Created attachment 29154 [details]
Comment 2 Dimitri Glazkov (Google) 2009-04-01 09:16:07 PDT
Comment on attachment 29154 [details]

Looks good -- one question? For DOM exception handling, can we use the throwError(ExceptionCode) helper from V8Proxy.h? It returns v8::Undefined(), but that should still work. Right?
Comment 3 Dimitri Glazkov (Google) 2009-04-01 09:17:25 PDT
Comment on attachment 29154 [details]

Doh! I think Node.idl change is missing from the patch.
Comment 4 Mike Belshe 2009-04-05 14:17:09 PDT
Created attachment 29267 [details]
updated patch to address comments.

Sorry for the clerical error; Node.idl changes attached.
Comment 5 Dimitri Glazkov (Google) 2009-04-06 11:09:21 PDT
Landed as http://trac.webkit.org/changeset/42248.