RESOLVED FIXED 24978
Add V8 custom bindings for Node insert/remove methods 
https://bugs.webkit.org/show_bug.cgi?id=24978
Summary Add V8 custom bindings for Node insert/remove methods
Mike Belshe
Reported 2009-03-31 19:42:55 PDT
This change allows us to take advantage of WebKit's lazyattach, which provides a significant performance win on dom manipulations.
Attachments
patch (3.74 KB, patch)
2009-03-31 19:48 PDT, Mike Belshe 		dglazkov: review-
DetailsFormatted DiffDiff
updated patch to address comments. (4.96 KB, patch)
2009-04-05 14:17 PDT, Mike Belshe 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Belshe
Comment 1 2009-03-31 19:48:50 PDT
Created attachment 29154 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-04-01 09:16:07 PDT
Comment on attachment 29154 [details] patch Looks good -- one question? For DOM exception handling, can we use the throwError(ExceptionCode) helper from V8Proxy.h? It returns v8::Undefined(), but that should still work. Right?
Dimitri Glazkov (Google)
Comment 3 2009-04-01 09:17:25 PDT
Comment on attachment 29154 [details] patch Doh! I think Node.idl change is missing from the patch.
Mike Belshe
Comment 4 2009-04-05 14:17:09 PDT
Created attachment 29267 [details] updated patch to address comments. Sorry for the clerical error; Node.idl changes attached.
Dimitri Glazkov (Google)
Comment 5 2009-04-06 11:09:21 PDT
Landed as http://trac.webkit.org/changeset/42248.
Note You need to log in before you can comment on or make changes to this bug.