Bug 25040 - Make SecurityOrigin thread safe.
Summary: Make SecurityOrigin thread safe.
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 24492
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-03 15:32 PDT by Jian Li
Modified: 2009-06-13 22:31 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-04-03 15:32:22 PDT
We need to make SecurityOrigin thread safe, i.e., the way to initialize static values in SecurityOrigin and other classes it calls. Considering moving all statics into one place and use TLS.

Currently we assume that main thread will initialize a document and thus create a SecurityOrigin before any other thread that uses WebKit is run.
Comment 1 Darin Fisher (:fishd, Google) 2009-04-03 15:53:38 PDT
I don't think TLS is a good answer.  What if someone modifies these tables lazily?
Comment 2 Alexey Proskuryakov 2009-04-04 02:21:27 PDT
Yes, I do not see how TLS would be relevant here.

What we really need is to move SecurityOrigin checks out of XMLHttpRequest and into DocumentThreadableLoader.
Comment 3 Darin Fisher (:fishd, Google) 2009-06-13 22:31:45 PDT
> What we really need is to move SecurityOrigin checks out of XMLHttpRequest and
> into DocumentThreadableLoader.

So that makes this bug WONTFIX right?  The implication being that SecurityOrigin checks will then only run on the WebKit main thread.