Move Local and NoAccess security rules from FrameLoader to SecurityOrigin This bug is about moving the following functions: registerURLSchemeAsLocal shouldTreatURLAsLocal shouldTreatURLSchemeAsLocal registerURLSchemeAsNoAccess shouldTreatURLSchemeAsNoAccess I also question whether we should keep shouldTreatURLAsLocal. It seems a bit unnecessary.
There is some related discussion in bug 24437.
We also need to make SecurityOrigin thread safe. Considering making all statics use TLS.
I think that should be turned into a separate bug. This one is just above moving some code, which is what I plan to do.
Hm. Interesting. This seems a bit related to https://bugs.webkit.org/show_bug.cgi?id=26143 ("SecurityOrigin should probably be split into Origin and EffectiveScriptOrigin").
Stealing. This is low hanging fruit on my quest to tame FrameLoader.
Created attachment 31251 [details] patchy
Comment on attachment 31251 [details] patchy > +2009-06-13 Adam Barth <abarth@webkit.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from > + FrameLoader to SecurityOrigin. > + nit: provide a bug reference. same goes for the other ChangeLogs. R=me
> nit: provide a bug reference. same goes for the other ChangeLogs. Thanks. I have trouble remembering to do that for some reason.
Fixed in http://trac.webkit.org/changeset/44664.