Bug 249608 - webkitcorepy.tests.file_lock_unittest.FileLockTestCase.test_locked_timeout is randomly failing
Summary: webkitcorepy.tests.file_lock_unittest.FileLockTestCase.test_locked_timeout is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-19 13:46 PST by Fujii Hironori
Modified: 2023-01-23 13:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2022-12-19 14:13 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2022-12-20 03:59 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-12-19 13:46:49 PST 
webkitcorepy.tests.file_lock_unittest.FileLockTestCase.test_locked_timeout is randomly failing

https://build.webkit.org/#/builders/699/builds/692

[121/2385] webkitcorepy.tests.file_lock_unittest.FileLockTestCase.test_locked_timeout failed:
  Traceback (most recent call last):
    File "/Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/file_lock_unittest.py", line 95, in test_locked_timeout
      self.assertEqual(start_time + 30, int(time.time()))
  AssertionError: 1671177453 != 1671177454
Comment 1 Fujii Hironori 2022-12-19 13:51:28 PST 
This test was added by 241905@main (bug#230320).
Comment 2 Fujii Hironori 2022-12-19 14:13:03 PST 
Created attachment 464108 [details]
Patch
Comment 3 Fujii Hironori 2022-12-19 16:18:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7881
Comment 4 Fujii Hironori 2022-12-20 03:59:37 PST 
Created attachment 464115 [details]
Patch
Comment 5 EWS 2022-12-20 12:18:28 PST 
Committed 258154@main (81d0d71c7efa): <https://commits.webkit.org/258154@main>

Reviewed commits have been landed. Closing PR #7881 and removing active labels.
Comment 6 Radar WebKit Bug Importer 2022-12-20 12:19:15 PST 
<rdar://problem/103566660>
Comment 7 Jonathan Bedard 2023-01-19 10:45:40 PST 
Re-opening for pull request https://github.com/apple/WebKit/pull/300
Comment 8 EWS 2023-01-23 13:47:33 PST 
Committed 252432.1037@safari-7614-branch (846e2a69bcaa): <https://commits.webkit.org/252432.1037@safari-7614-branch>

Reviewed commits have been landed. Closing PR #300 and removing active labels.