Bug 230320 - [webkitcorepy] Move FileLock from webkitpy
Summary: [webkitcorepy] Move FileLock from webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-15 14:40 PDT by Jonathan Bedard
Modified: 2021-09-20 12:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (24.65 KB, patch)
2021-09-15 14:43 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (25.36 KB, patch)
2021-09-20 11:31 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-09-15 14:40:11 PDT
The mechanics of our webkitpy FileLock are good, but the API is not. Move webkitpy's FileLock into webkitcorepy and clarify the API.
Comment 1 Radar WebKit Bug Importer 2021-09-15 14:40:45 PDT
<rdar://problem/83168826>
Comment 2 Jonathan Bedard 2021-09-15 14:43:04 PDT
Created attachment 438292 [details]
Patch
Comment 3 dewei_zhu 2021-09-20 10:28:54 PDT
Comment on attachment 438292 [details]
Patch

r=me
Comment 4 Jonathan Bedard 2021-09-20 11:31:46 PDT
Created attachment 438703 [details]
Patch for landing
Comment 5 EWS 2021-09-20 12:52:41 PDT
Committed r282770 (241905@main): <https://commits.webkit.org/241905@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438703 [details].