RESOLVED FIXED Bug 230320
[webkitcorepy] Move FileLock from webkitpy 
https://bugs.webkit.org/show_bug.cgi?id=230320
Summary [webkitcorepy] Move FileLock from webkitpy
Jonathan Bedard
Reported 2021-09-15 14:40:11 PDT
The mechanics of our webkitpy FileLock are good, but the API is not. Move webkitpy's FileLock into webkitcorepy and clarify the API.
Attachments
Patch (24.65 KB, patch)
2021-09-15 14:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.36 KB, patch)
2021-09-20 11:31 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-15 14:40:45 PDT
<rdar://problem/83168826>
Jonathan Bedard
Comment 2 2021-09-15 14:43:04 PDT
Created attachment 438292 [details] Patch
dewei_zhu
Comment 3 2021-09-20 10:28:54 PDT
Comment on attachment 438292 [details] Patch r=me
Jonathan Bedard
Comment 4 2021-09-20 11:31:46 PDT
Created attachment 438703 [details] Patch for landing
EWS
Comment 5 2021-09-20 12:52:41 PDT
Committed r282770 (241905@main): <https://commits.webkit.org/241905@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438703 [details].
Fujii Hironori
Comment 6 2022-12-19 13:50:32 PST
Comment on attachment 438703 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=438703&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/file_lock_unittest.py:95 > + self.assertEqual(start_time + 30, int(time.time())) This check is too strict. Bug 249608 – webkitcorepy.tests.file_lock_unittest.FileLockTestCase.test_locked_timeout is randomly failing
Note You need to log in before you can comment on or make changes to this bug.