WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248784
Avoid uint64_t overflow in Decimal::operator/()
https://bugs.webkit.org/show_bug.cgi?id=248784
Summary
Avoid uint64_t overflow in Decimal::operator/()
Ahmad Saleem
Reported
2022-12-05 14:06:16 PST
Hi Team, While going through Blink's commit, I found another failing test case: Blink Commit -
https://src.chromium.org/viewvc/blink?view=revision&revision=191294
Failing Test Case -
https://jsfiddle.net/rerich/pn1o3wvn/
(^ First range is at 'zero' compared to Chrome / Blink). Just wanted to raise this bug so it can be merged or fixed. Unfortunately, I will not be able to do it because the test is in C++ and I am not able to do it in this
bug 247514
, appreciate if someone can fix both in one go. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2022-12-08 06:45:52 PST
> Unfortunately, I will not be able to do it because the test is in C++
While it's not ideal, importing the failing test case linked above (with input type=range), converting it to a reftest, would be better than nothing. Unless this ends up exposed through the DOM API?
Radar WebKit Bug Importer
Comment 2
2022-12-12 14:07:16 PST
<
rdar://problem/103269252
>
Ahmad Saleem
Comment 3
2022-12-20 08:40:32 PST
(In reply to Sam Sneddon [:gsnedders] from
comment #1
)
> > Unfortunately, I will not be able to do it because the test is in C++ > > While it's not ideal, importing the failing test case linked above (with > input type=range), converting it to a reftest, would be better than nothing. > Unless this ends up exposed through the DOM API?
Managed to figure out the ref-test. PR -
https://github.com/WebKit/WebKit/pull/7908
EWS
Comment 4
2022-12-20 18:49:32 PST
Committed
258174@main
(d16c8e20b19e): <
https://commits.webkit.org/258174@main
> Reviewed commits have been landed. Closing PR #7908 and removing active labels.
Brent Fulgham
Comment 5
2024-01-23 16:52:16 PST
***
Bug 247514
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug