Bug 247514 – Fix MaxCoefficient static variable value in Decimal.cpp

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Ahmad Saleem]

Hi Team,

Just going through Blink Commits, came across following commit:

Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=174294

and Webkit is still using wrong one, I think matching would be fine rather than updating comment to reflect current value.

https://github.com/WebKit/WebKit/blob/06829a72816b3507674af7be8a740a4964ae3518/Source/WebCore/platform/Decimal.cpp#L51

I am just creating this bug to do PR and merge above commit.

Let me know if someone want me to just update comment.

Thanks!

[Alexey Proskuryakov]

[e-mail]! Sadly, no test modified in the commit.

[Ahmad Saleem]

(In reply to Alexey Proskuryakov from comment #1)
> [e-mail]! Sadly, no test modified in the commit.

https://github.com/WebKit/WebKit/pull/6160

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #2)
> (In reply to Alexey Proskuryakov from comment #1)
> > [e-mail]! Sadly, no test modified in the commit.
> 
> https://github.com/WebKit/WebKit/pull/6160

Latest position is that whether there is std:decimal to replace our use case or whether we just add 'DecmialTest.cpp' API for testing similar to Chrome.

[Chris Dumez]

(In reply to Alexey Proskuryakov from comment #1)
> [e-mail]! Sadly, no test modified in the commit.

There were tests modified in MY commit :)

[Radar WebKit Bug Importer]

<rdar://problem/102261978>

[Ahmad Saleem]

Will fix via https://github.com/WebKit/WebKit/pull/7908 in one go with test-case as well.

[Brent Fulgham]

*** This bug has been marked as a duplicate of bug 248784 ***