RESOLVED DUPLICATE of bug 118684 248367
compositionstart event's data should contain text to replace 
https://bugs.webkit.org/show_bug.cgi?id=248367
Summary compositionstart event's data should contain text to replace
Ahmad Saleem
Reported 2022-11-26 17:15:25 PST
Hi Team, I was going through Blink commits and found another case, which can be merged: Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/b336a53b180ca88e40fef99e7f0a0779bd3d5986/Source/WebCore/editing/Editor.cpp#L2161 Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=153319 Just wanted to raise this bug before trying to do PR. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Karl Dubost
Comment 1 2022-11-27 18:53:37 PST
This was done in Bug 118684 by Ryosuke in July 2013! > "to match IE and Firefox behaviors" So why it's not here anymore. Ah Ryosuke is mentioning that his patch was simpler by just calling `selectedText()` https://chromiumcodereview.appspot.com/18041002#msg10 selectedText() was later renamed as originalText https://github.com/WebKit/WebKit/commit/c824bf1ebb4be32e85df6256fe0619a22a637019#diff-298ab5f43228bb977d82fadbd60cad9a87bb25aa0e3eabdb77779a8455136d0bR1872-R1883 Adding Ryosuke, to know if this change is really necessary.
Ahmad Saleem
Comment 2 2022-11-28 05:02:07 PST
Marking as Duplicate - since Blink commit was same. So no need to do it again. Thanks! *** This bug has been marked as a duplicate of bug 118684 ***
Note You need to log in before you can comment on or make changes to this bug.