Bug 118684 - compositionstart event should contain the text to be replaced
Summary: compositionstart event should contain the text to be replaced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
: 248367 (view as bug list)
Depends on:
Blocks: 118688
  Show dependency tree / graph
 
Reported: 2013-07-15 14:32 PDT by Ryosuke Niwa
Modified: 2022-11-28 05:02 PST (History)
7 users (show)

See Also:

Attachments
Fixes the bug (4.92 KB, patch)
2013-07-15 14:45 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Test case (191 bytes, text/html)
2013-07-15 14:59 PDT, Ryosuke Niwa 		no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (493.07 KB, application/zip)
2013-07-15 15:40 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-15 14:32:34 PDT 
Merge https://chromium.googlesource.com/chromium/blink/+/9e04f728a95ad7d4783b1d31c3cdc1412dd6cc4d to match IE and Firefox behaviors.
Comment 1 Ryosuke Niwa 2013-07-15 14:45:48 PDT 
Created attachment 206686 [details]
Fixes the bug
Comment 2 Alexey Proskuryakov 2013-07-15 14:51:22 PDT 
Comment on attachment 206686 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=206686&action=review

> Source/WebCore/ChangeLog:14
> +        According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
> +        to the specified behavior.

Could you please test Firefox on Mac?
Comment 3 Ryosuke Niwa 2013-07-15 14:59:09 PDT 
Created attachment 206688 [details]
Test case

(In reply to comment #2)
> (From update of attachment 206686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206686&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
> > +        to the specified behavior.
> 
> Could you please test Firefox on Mac?

Confirmed on Firefox 21.
Comment 4 Build Bot 2013-07-15 15:40:01 PDT 
Comment on attachment 206686 [details]
Fixes the bug

Attachment 206686 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1065960

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html
Comment 5 Build Bot 2013-07-15 15:40:03 PDT 
Created attachment 206695 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 6 Ryosuke Niwa 2013-07-15 16:28:05 PDT 
Comment on attachment 206686 [details]
Fixes the bug

Clearing flags on attachment: 206686

Committed r152668: <http://trac.webkit.org/changeset/152668>
Comment 7 Ryosuke Niwa 2013-07-15 16:28:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Ahmad Saleem 2022-11-28 05:02:07 PST 
*** Bug 248367 has been marked as a duplicate of this bug. ***