RESOLVED FIXED 247364
Remove CSSKeyframesRule.insertRule() 
https://bugs.webkit.org/show_bug.cgi?id=247364
Summary Remove CSSKeyframesRule.insertRule()
Ahmad Saleem
Reported 2022-11-02 08:06:14 PDT
Hi Team, I couldn't find bug so I am creating this to alias "insertRule" as "append" or remove since it was removed in Blink (2015) and was never supported by Gecko & Internet Explorer 11. Web-Spec - https://drafts.csswg.org/css-animations/#interface-csskeyframesrule Blink commit for aliasing - https://src.chromium.org/viewvc/blink?view=revision&revision=194122 Blink commit for removing - https://src.chromium.org/viewvc/blink?view=revision&revision=195797 Current IDL file - https://github.com/WebKit/WebKit/blob/1a4522de8a5d226a336c85237dd15144174fadfc/Source/WebCore/css/CSSKeyframesRule.idl#L35 It shows that we still support this. Just wanted to create a bug for future purposes to remove this and align with Web-Specs. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-11-02 13:59:44 PDT
We intentionally kept it in bug 57910, but perhaps it's less relevant now. Could be difficult to confirm.
Karl Dubost
Comment 2 2022-11-04 00:21:40 PDT
Intent to Remove for Blink in 2015 https://groups.google.com/a/chromium.org/g/blink-dev/c/wW7w8Hro78s/m/JDULF2oM9iIJ Changed in Gecko in 2013 https://bugzilla.mozilla.org/show_bug.cgi?id=841896
Karl Dubost
Comment 3 2022-11-04 00:24:25 PDT
Also has a finger in the wind evaluation. https://cs.github.com/?scopeName=All+repos&scope=&q=CSSKeyframesRule.insertRule+language%3AJavaScript 0 match on GitHub code.
Radar WebKit Bug Importer
Comment 4 2022-11-09 07:07:17 PST
<rdar://problem/102141002>
Karl Dubost
Comment 5 2022-12-27 22:55:22 PST
Pull request: https://github.com/WebKit/WebKit/pull/8084
EWS
Comment 6 2022-12-30 03:16:04 PST
Committed 258361@main (c26a65e62e39): <https://commits.webkit.org/258361@main> Reviewed commits have been landed. Closing PR #8084 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.