Bug 24356 - Rename AllowUniversalAccessFromFileUrls to AllowUniversalAccessFromFileURLs
Summary: Rename AllowUniversalAccessFromFileUrls to AllowUniversalAccessFromFileURLs
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-03-04 09:31 PST by Adam Barth
Modified: 2009-03-04 12:32 PST (History)
2 users (show)

See Also:

patch (17.23 KB, patch)
2009-03-04 10:00 PST, Adam Barth
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-03-04 09:31:32 PST
WebKit style fail.
Comment 1 Alexey Proskuryakov 2009-03-04 10:00:05 PST
Per bug 24340 comment 4, Qt API should probably remain an exception.
Comment 2 Adam Barth 2009-03-04 10:00:21 PST
Created attachment 28267 [details]

I left the Qt parts in Qt style (i.e., Url).
Comment 3 Alexey Proskuryakov 2009-03-04 11:24:06 PST
Comment on attachment 28267 [details]

r=me. Thanks!

-        } else if(settings->allowUniversalAccessFromFileUrls() && securityOrigin()->isLocal()) {
+        } else if(settings->allowUniversalAccessFromFileURLs() && securityOrigin()->isLocal()) {

Please add a space after if here.
Comment 4 Adam Barth 2009-03-04 11:59:00 PST
Sending        WebCore/ChangeLog
Sending        WebCore/WebCore.base.exp
Sending        WebCore/dom/Document.cpp
Sending        WebCore/page/Settings.cpp
Sending        WebCore/page/Settings.h
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/WebView/WebPreferenceKeysPrivate.h
Sending        WebKit/mac/WebView/WebPreferences.mm
Sending        WebKit/mac/WebView/WebPreferencesPrivate.h
Sending        WebKit/mac/WebView/WebView.mm
Sending        WebKit/qt/Api/qwebsettings.cpp
Sending        WebKit/qt/ChangeLog
Sending        WebKit/win/ChangeLog
Sending        WebKit/win/Interfaces/IWebPreferencesPrivate.idl
Sending        WebKit/win/WebPreferenceKeysPrivate.h
Sending        WebKit/win/WebPreferences.cpp
Sending        WebKit/win/WebPreferences.h
Sending        WebKit/win/WebView.cpp
Transmitting file data ..................
Committed revision 41426.

I'll mark this bug as fixed once the buildbots give us the green light.