Bug 24340 - Expose allowUniversalAccessFromFileUrls to Qt
Summary: Expose allowUniversalAccessFromFileUrls to Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-03 17:46 PST by Adam Barth
Modified: 2009-03-04 09:39 PST (History)
2 users (show)

See Also:


Attachments
patch (2.80 KB, patch)
2009-03-03 18:02 PST, Adam Barth
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-03-03 17:46:38 PST
Clients of the QT port might want to set allowUniversalAccessFromFileUrls.  We should expose it in http://trac.webkit.org/browser/trunk/WebKit/qt/Api/qwebsettings.h
Comment 1 Adam Barth 2009-03-03 18:02:31 PST
Created attachment 28252 [details]
patch

I can't build QT, but this patch is trivially simple (meaning it will probably only break the build in two ways).
Comment 2 Alexey Proskuryakov 2009-03-04 00:20:37 PST
QT is QuickTime, re-titling.
Comment 3 Alexey Proskuryakov 2009-03-04 00:29:38 PST
Comment on attachment 28252 [details]
patch

+        Reviewed by NOBODY (OOPS!).
+
+        Expose AllowUniversalAccessFromFileUrls to QT clients.

Please add a bug URL.

r=me, but AllowUniversalAccessFromFileUrls should really be AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's particularly unfortunate to have this exposed as a (private) preference, could you please rename all instances? A separate patch would probably be more appropriate.
Comment 4 Brian Ellis 2009-03-04 00:40:54 PST
(In reply to comment #3)

> r=me, but AllowUniversalAccessFromFileUrls should really be
> AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's
> particularly unfortunate to have this exposed as a (private) preference, could
> you please rename all instances? A separate patch would probably be more
> appropriate.

"URL" is consistent with the naming of preferences in WebCore, but Qt uses "Url" instead of "URL" pretty universally -- see e.g. the QUrl class and the QWebPage method "userAgentForUrl".  Perhaps it should be left alone in QtWebKit and changed elsewhere?
Comment 5 Adam Barth 2009-03-04 09:34:00 PST
> could you please rename all instances? A separate patch would probably be more
> appropriate.

Filed as: https://bugs.webkit.org/show_bug.cgi?id=24356
Comment 6 Adam Barth 2009-03-04 09:39:59 PST
Sending        WebKit/qt/Api/qwebsettings.cpp
Sending        WebKit/qt/Api/qwebsettings.h
Sending        WebKit/qt/ChangeLog
Transmitting file data ...
Committed revision 41421.