Bug 243449 – [CSS Container Queries] Update query grammar to the spec

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

The spec was changed to allow logical operators on top level without parenthesis making

@container not (foo)

legal.

https://drafts.csswg.org/css-contain-3/#container-rule

[Radar WebKit Bug Importer]

<rdar://problem/97967682>

[Antti Koivisto]

Created attachment 461354 [details]
Patch

[Antti Koivisto]

Created attachment 461355 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 461355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461355&action=review

> Source/WebCore/css/ContainerQueryParser.cpp:98
>  

For posterity (and anyone else looking at this patch), the `not` part is handled just below (click expand to make it appear in the diff view).

> Source/WebCore/css/StyleRule.cpp:466
> +    , m_containerdQuery(WTFMove(query))
>  {
>  }
>  
>  StyleRuleContainer::StyleRuleContainer(const StyleRuleContainer& other)
>      : StyleRuleGroup(other)
> -    , m_filteredQuery(other.m_filteredQuery)
> +    , m_containerdQuery(other.m_containerdQuery)

typo: m_containerdQuery (extra d)

> Source/WebCore/css/StyleRule.h:303
> +    CQ::ContainerQuery m_containerdQuery;

ditto in this file

[Antti Koivisto]

Created attachment 461357 [details]
Patch for landing

[EWS]

Commit message contains (OOPS!), blocking PR #None

[Antti Koivisto]

Created attachment 461358 [details]
Patch for landing

[EWS]

Committed 253035@main (2956c932c8f4): <https://commits.webkit.org/253035@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461358 [details].