Bug 243142 - [LFC][IFC] LineBoxVerticalAligner should keep track of if annotation is present
Summary: [LFC][IFC] LineBoxVerticalAligner should keep track of if annotation is present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 243138
  Show dependency treegraph
 
Reported: 2022-07-23 15:22 PDT by zalan
Modified: 2022-07-25 07:18 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.94 KB, patch)
2022-07-23 15:28 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.06 KB, patch)
2022-07-24 21:06 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-07-23 15:22:39 PDT
ssia
Comment 1 zalan 2022-07-23 15:28:09 PDT
Created attachment 461164 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-07-24 14:00:49 PDT
Comment on attachment 461164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461164&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:138
> +    auto conentHasAnnotation = rootInlineBox.hasAnnotation();

typo: contentHasAnnotation
Comment 3 zalan 2022-07-24 21:06:57 PDT
Created attachment 461189 [details]
Patch
Comment 4 EWS 2022-07-25 07:17:20 PDT
Committed 252783@main (f09b4a921c61): <https://commits.webkit.org/252783@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461189 [details].
Comment 5 Radar WebKit Bug Importer 2022-07-25 07:18:18 PDT
<rdar://problem/97549115>