Bug 243138 - [LFC][IFC] Add support for text-emphasis
Summary: [LFC][IFC] Add support for text-emphasis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 243137 243139 243140 243141 243142 243143 243144
Blocks:
  Show dependency tree / graph
 
Reported: 2022-07-23 14:13 PDT by zalan
Modified: 2022-07-27 19:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2022-07-23 16:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.01 KB, patch)
2022-07-23 16:28 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (16.44 KB, patch)
2022-07-27 13:46 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-07-23 14:13:15 PDT 
ssia
Comment 1 zalan 2022-07-23 16:19:23 PDT 
Created attachment 461167 [details]
Patch
Comment 2 zalan 2022-07-23 16:22:57 PDT 
1. Enable text-emphasis painting for modern line layout codepath
2. Add support for float based emphasis content height
3. InlineLevelBox caches annotation content height
4. Bail out of simplified vertical alignment when annotation is present
5. Prepare LineBoxVerticalAligner for dealing with annotation adjustment
6. Implement vertical alignment with annotation
7. Adjust enclosing content geometry/ink overflow with annotation content size
Comment 3 zalan 2022-07-23 16:28:45 PDT 
Created attachment 461168 [details]
Patch
Comment 4 zalan 2022-07-27 13:46:41 PDT 
Created attachment 461261 [details]
[fast-cq]Patch
Comment 5 EWS 2022-07-27 19:05:25 PDT 
Committed 252889@main (574ed4eaf203): <https://commits.webkit.org/252889@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461261 [details].
Comment 6 Radar WebKit Bug Importer 2022-07-27 19:06:17 PDT 
<rdar://problem/97697028>