WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24313
hitTest() on a single line input only works through happenstance.
https://bugs.webkit.org/show_bug.cgi?id=24313
Summary
hitTest() on a single line input only works through happenstance.
Simon Fraser (smfr)
Reported
2009-03-02 20:09:20 PST
Hit testing on a RenderTextControlSingleLine seems to work only because of a side-effect of HitTestResult behavior. What I see happening is this. RenderLayer::hitTest calls hitTest() on the renderer, which goes into RenderTextControlSingleLine::nodeAtPoint(). This ends up setting the TextControlInnerTextElement as the innerNode() on the result. However, RenderTextControlSingleLine::nodeAtPoint() then returns false! So we continue to hit test all the way up to the body. The body's layer ends up being the one hit, but we use the node in the result anyway. This is hurting my karma. See
bug 24312
.
Attachments
Patch
(1.54 KB, patch)
2009-03-02 21:46 PST
,
Simon Fraser (smfr)
adele
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2009-03-02 21:46:48 PST
Created
attachment 28212
[details]
Patch I'm pretty sure it was just wrong to test against m_innerBlock, because the superclass could never have set that on the result.
Simon Fraser (smfr)
Comment 2
2009-03-02 22:16:19 PST
http://trac.webkit.org/changeset/41379
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug