Bug 24312 – Hit test through 3d transforms

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

We need to have hit testing be aware of 3d transforms, and preserve-3d style.

[Simon Fraser (smfr)]

Created attachment 28214 [details]
Patch, changelog.

Testcases will be added once we turn on support for 3d rendering.

[Simon Fraser (smfr)]

Created attachment 28224 [details]
Prequel patch: refactor code into transformFromContainer()

[Dave Hyatt]

Comment on attachment 28224 [details]
Prequel patch: refactor code into transformFromContainer()

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index e7b3153..0256ec1 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -2,6 +2,22 @@
>  
>          Reviewed by NOBODY (OOPS!).
>  
> +        https://bugs.webkit.org/show_bug.cgi?id=24312
> +        
> +        Factor the code that compute a transform relative to the container
> +        into RenderObject::transformFromContainer().
> +      

"that computes a transform"

r=me

[Dave Hyatt]

Comment on attachment 28214 [details]
Patch, changelog.

"Recurses through the layer hieraarchy"

Actually just remove this comment.  I think it's just confusing.  hit testing doesn't go through the parent/child hierarchy, which is what the comment implies.

[Simon Fraser (smfr)]

Prequel patch:
http://trac.webkit.org/changeset/41387

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/41389

[Simon Fraser (smfr)]

*** Bug 24573 has been marked as a duplicate of this bug. ***

[Kari Hiitola]

I tested with the latest nightly on a Mac, and the hit testing really doesn't seem to work as it should. If you try the test page of the duplicate bug: https://bugs.webkit.org/attachment.cgi?id=28576 the child div can not be clicked. I would suggest reopening this bug. 

[Simon Fraser (smfr)]

Kari: I believe the issue that breaks your is covered by bug 24659.