RESOLVED FIXED 243078
[Wasm-GC] Make GC tests more maintainable 
https://bugs.webkit.org/show_bug.cgi?id=243078
Summary [Wasm-GC] Make GC tests more maintainable
Asumu Takikawa
Reported 2022-07-21 14:25:33 PDT
Currently the Wasm GC tests (structs.js and i31.js for example) are written with binary strings with comments indicating the Wasm text format module that they correspond to. A recent review comment (https://github.com/WebKit/WebKit/pull/2202#discussion_r916963742) suggested improving the situation with a script to ensure the binary format matches the text, to ensure maintainability. Another possible solution is to embed a text format encoder/decoder that supports the Wasm GC proposal. One way to do this is to compile the Wasm specification reference interpreter to JS, and embed that in the tests. I'll attach a patch that illustrates this approach for the current tests.
Attachments
Add attachment proposed patch, testcase, etc.
Asumu Takikawa
Comment 1 2022-07-21 17:15:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2643
EWS
Comment 2 2022-07-26 08:43:24 PDT
Committed 252823@main (52534d6449a4): <https://commits.webkit.org/252823@main> Reviewed commits have been landed. Closing PR #2643 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-07-26 08:44:17 PDT
<rdar://problem/97608052>
Note You need to log in before you can comment on or make changes to this bug.