WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
242242
[browserperfdash-benchmark] Fix error logging from server after
251530@main
(port to python3)
https://bugs.webkit.org/show_bug.cgi?id=242242
Summary
[browserperfdash-benchmark] Fix error logging from server after 251530@main (...
Carlos Alberto Lopez Perez
Reported
2022-07-01 04:53:06 PDT
On
251530@main
(
r295525
) the script browserperfdash-runner was ported to python3 and it is working fine. However, when the browserperfdash server replies with an error (http error code: 400) the script is not longer logging what caused the error (the body of the http reply) on stderr. Instead it is causing a generic exception that doesn't give any helpful info for debugging the problem. Previously (with python2) the script was giving useful info. This seems to be caused because on python3 urllib.request.urlopen always rises when the http error code is not 200.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2022-07-01 05:03:00 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1989
EWS
Comment 2
2022-07-01 07:34:51 PDT
Committed
252040@main
(c0299cc3d772): <
https://commits.webkit.org/252040@main
> Reviewed commits have been landed. Closing PR #1989 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-07-01 07:35:13 PDT
<
rdar://problem/96290581
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug