Bug 230098 - [GTK][RunBenchmarkTests][BrowserperfDash] Port to Python3
Summary: [GTK][RunBenchmarkTests][BrowserperfDash] Port to Python3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kevin Neal
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-09 08:13 PDT by Kevin Neal
Modified: 2022-07-01 04:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2021-09-09 08:16 PDT, Kevin Neal 		no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2021-09-09 13:11 PDT, Kevin Neal 		no flags Details | Formatted Diff | Diff
Patch (3.96 KB, patch)
2022-06-14 03:07 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Neal 2021-09-09 08:13:12 PDT 
RunBenchmarkTests (browserperfdash-benchmark) should be invoked with Python 3.
Comment 1 Radar WebKit Bug Importer 2021-09-09 08:14:55 PDT 
<rdar://problem/82925374>
Comment 2 Kevin Neal 2021-09-09 08:16:35 PDT 
Created attachment 437744 [details]
Patch
Comment 3 Kevin Neal 2021-09-09 13:11:35 PDT 
Created attachment 437772 [details]
Patch
Comment 4 Carlos Alberto Lopez Perez 2021-10-05 18:35:56 PDT 
Comment on attachment 437772 [details]
Patch

This script needs to be ported to python3. I have tested, and is still not compatible with it.
Comment 5 Carlos Alberto Lopez Perez 2022-06-14 03:00:29 PDT 
I'm uploading a patch porting the scripts to use python3
Comment 6 Carlos Alberto Lopez Perez 2022-06-14 03:07:34 PDT 
Created attachment 460228 [details]
Patch
Comment 7 Aakash Jain 2022-06-14 09:24:50 PDT 
Comment on attachment 460228 [details]
Patch

r+ assuming this is tested
Comment 8 EWS 2022-06-14 10:07:54 PDT 
Committed r295525 (251530@main): <https://commits.webkit.org/251530@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460228 [details].
Comment 9 Aakash Jain 2022-06-15 06:18:53 PDT 
Restarted buildbot to pick up this change