Bug 242000 - Fix block-aspect-ratio-037.html
Summary: Fix block-aspect-ratio-037.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
: 231775 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-06-25 03:14 PDT by Rob Buis
Modified: 2022-06-29 06:58 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2022-06-25 03:26 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (5.17 KB, patch)
2022-06-27 06:21 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-06-25 03:14:55 PDT 
Fix block-aspect-ratio-037.html.
Comment 1 Rob Buis 2022-06-25 03:26:21 PDT 
Created attachment 460490 [details]
Patch
Comment 2 EWS Watchlist 2022-06-25 03:28:22 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Darin Adler 2022-06-26 16:54:26 PDT 
Comment on attachment 460490 [details]
Patch

r=me

Is the single regression test sufficient coverage for both code changes?
Comment 4 Rob Buis 2022-06-27 06:21:35 PDT 
Created attachment 460502 [details]
Patch
Comment 5 Rob Buis 2022-06-28 05:47:22 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 460490 [details]
> Patch
> 
> r=me
> 
> Is the single regression test sufficient coverage for both code changes?

The change in constrainLogicalHeightByMinMax is covered by aspect-ratio/grid-aspect-ratio-022.html.
Comment 6 EWS 2022-06-28 05:54:27 PDT 
Committed 251908@main (e97db329a49a): <https://commits.webkit.org/251908@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460502 [details].
Comment 7 Radar WebKit Bug Importer 2022-06-28 05:55:12 PDT 
<rdar://problem/96055491>
Comment 8 Rob Buis 2022-06-29 06:58:35 PDT 
*** Bug 231775 has been marked as a duplicate of this bug. ***