Bug 24197 - ColorCG.cpp: Windows version of cgColor() is ifdefed on !PLATFORM(MAC) which is true for Chrome on OS X
Summary: ColorCG.cpp: Windows version of cgColor() is ifdefed on !PLATFORM(MAC) which ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-26 04:59 PST by Jeremy Moskovich
Modified: 2009-03-02 21:42 PST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2009-02-26 04:59:37 PST
PLATFORM(MAC) isn't defined for Chrome, so on OS X we're picking up the Windows version of cgColor() from ColorCG.cpp rather than the Mac version from ColorMac.mm.

The define needs to be changed to either use !PLATFORM(DARWIN) or PLATFORM(WIN) so Chrome on OS X doesn't pick up the Windows version.

https://bugs.webkit.org/show_bug.cgi?id=23512 also bears mentioning in this context.
Comment 1 Jeremy Moskovich 2009-03-02 00:42:02 PST
Fixed in r41345
Comment 2 Mark Mentovai 2009-03-02 21:42:46 PST
Jeremy, why did we want cgColor ColorMac.mm for mcChrome instead of ColorCG.cpp?  I just helped Pam out with this for the merge (she'll probably contact you separately about focusRingColor), but I don't understand why you wanted this change, it seems like it's going in the wrong direction.