RESOLVED FIXED 24197
ColorCG.cpp: Windows version of cgColor() is ifdefed on !PLATFORM(MAC) which is true for Chrome on OS X 
https://bugs.webkit.org/show_bug.cgi?id=24197
Summary ColorCG.cpp: Windows version of cgColor() is ifdefed on !PLATFORM(MAC) which ...
Jeremy Moskovich
Reported 2009-02-26 04:59:37 PST
PLATFORM(MAC) isn't defined for Chrome, so on OS X we're picking up the Windows version of cgColor() from ColorCG.cpp rather than the Mac version from ColorMac.mm. The define needs to be changed to either use !PLATFORM(DARWIN) or PLATFORM(WIN) so Chrome on OS X doesn't pick up the Windows version. https://bugs.webkit.org/show_bug.cgi?id=23512 also bears mentioning in this context.
Attachments
Add attachment proposed patch, testcase, etc.
Jeremy Moskovich
Comment 1 2009-03-02 00:42:02 PST
Fixed in r41345
Mark Mentovai
Comment 2 2009-03-02 21:42:46 PST
Jeremy, why did we want cgColor ColorMac.mm for mcChrome instead of ColorCG.cpp? I just helped Pam out with this for the merge (she'll probably contact you separately about focusRingColor), but I don't understand why you wanted this change, it seems like it's going in the wrong direction.
Note You need to log in before you can comment on or make changes to this bug.