cgColor() returns a retained object, but the name doesn't communicate that. Bad!
Also the implementation of
is totally missing!
Odd. ColorCG.cpp exists, but is not in the Xcode project. It also has an implementation of cgColor() that uses the platform color space.
Created attachment 28014 [details]
Rename to createCGColor() per-irc conversation.
This also fixes https://bugs.webkit.org/show_bug.cgi?id=24197
Comment on attachment 28014 [details]
Yay! I like this change. Of course I might get yelled at by bdash for my continued disparate understanding of PLATFORM(MAC) vs. PLATFORM(DARWIN). :(
DARWIN really seems wrong to me for the uses of CMProfileRef. For now, maybe !WIN_OS would be better, since the more limited version of CG is the one on Windows.
Created attachment 28078 [details]
Fix per Darin's comments.
Comment on attachment 28078 [details]
Comitted as r41345.