Bug 24139 - ScriptInstance.h missing an #include
Summary: ScriptInstance.h missing an #include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Mark Mentovai
URL:
Keywords:
Depends on:
Blocks: 24109
  Show dependency tree / graph
 
Reported: 2009-02-24 14:39 PST by Mark Mentovai
Modified: 2009-02-24 15:23 PST (History)
2 users (show)

See Also:

Attachments
fix (876 bytes, patch)
2009-02-24 14:43 PST, Mark Mentovai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Mentovai 2009-02-24 14:39:55 PST 
There's an #include missing in WebCore/bindings/v8/ScriptInstance.h.  The file uses RefPtr.h and so should #include <wtf/RefPtr.h>.  Dimitri, you broke my build!
Comment 1 Mark Mentovai 2009-02-24 14:43:02 PST 
Created attachment 27937 [details]
fix
Comment 2 Eric Seidel (no email) 2009-02-24 14:53:04 PST 
Comment on attachment 27937 [details]
fix

Looks OK.
Comment 3 Dimitri Glazkov (Google) 2009-02-24 15:15:43 PST 
I break builds because it gives me false sense of power which offers momentary relief of the overwhelming feeling of insecurity.

BTW, why are you using these? I haven't updated the projects to use them yet :)
Comment 4 Mark Mentovai 2009-02-24 15:17:13 PST 
The gyp-based build is not bound by your puny project files.

I look for added files after WebKit merges and add them.  It's the only way to keep myself green.
Comment 5 Dimitri Glazkov (Google) 2009-02-24 15:18:40 PST 
Well, be careful young Jedi. The files in bindings/v8/custom lack corresponding inliners in V8Proxy, which I haven't yet landed.
Comment 6 Mark Mentovai 2009-02-24 15:21:17 PST 
Thanks, I'll pull them back out if I have to.

I was wondering how the missing #include didn't break any of the "proper" builds.

This change should still be checked in.
Comment 7 Dimitri Glazkov (Google) 2009-02-24 15:23:10 PST 
Landed as http://trac.webkit.org/changeset/41194.