Bug 24109 - Upstream V8 Script Abstraction
: Upstream V8 Script Abstraction
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
:
Depends on: 24139
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-23 15:52 PST by Dimitri Glazkov (Google)
Modified: 2009-02-23 20:05 PST (History)
0 users

See Also:


Attachments
Add V8 Script abstractions, v1 (34.52 KB, patch)
2009-02-23 15:54 PST, Dimitri Glazkov (Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-23 15:52:22 PST
.. with the exception of ScriptController, which needs to have its own, highly personalized bathing.
Comment 1 Dimitri Glazkov (Google) 2009-02-23 15:54:24 PST
Created attachment 27897 [details]
Add V8 Script abstractions, v1

 WebCore/ChangeLog                           |   66 +++++++++++++
 WebCore/bindings/v8/ScriptCachedFrameData.h |   52 ++++++++++
 WebCore/bindings/v8/ScriptCallFrame.cpp     |   62 ++++++++++++
 WebCore/bindings/v8/ScriptCallFrame.h       |   73 +++++++++++++++
 WebCore/bindings/v8/ScriptCallStack.cpp     |   58 ++++++++++++
 WebCore/bindings/v8/ScriptCallStack.h       |   59 ++++++++++++
 WebCore/bindings/v8/ScriptInstance.cpp      |   83 +++++++++++++++++
 WebCore/bindings/v8/ScriptInstance.h        |   63 +++++++++++++
 WebCore/bindings/v8/ScriptSourceCode.h      |   72 ++++++++++++++
 WebCore/bindings/v8/ScriptState.h           |   51 ++++++++++
 WebCore/bindings/v8/ScriptString.h          |   66 +++++++++++++
 WebCore/bindings/v8/ScriptValue.cpp         |   50 ++++++++++
 WebCore/bindings/v8/ScriptValue.h           |  134 +++++++++++++++++++++++++++
 13 files changed, 889 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel 2009-02-23 15:58:11 PST
Comment on attachment 27897 [details]
Add V8 Script abstractions, v1

Looks fine.  Only touches V8 code.
Comment 3 Mark Rowe (bdash) 2009-02-23 17:00:46 PST
Did this get landed?
Comment 4 Dimitri Glazkov (Google) 2009-02-23 20:05:27 PST
Landed as http://trac.webkit.org/changeset/41159.